Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: decouple framework and ens #585

Closed
wants to merge 16 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: comment updated for clarification
clauBv23 committed Apr 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit d65d50450fa2a2e93d2dd02377deae83bb433af5
2 changes: 1 addition & 1 deletion packages/contracts/src/framework/dao/DAORegistry.sol
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ contract DAORegistry is InterfaceBasedRegistry, ProtocolVersion {
bytes32 public constant REGISTER_DAO_PERMISSION_ID = keccak256("REGISTER_DAO_PERMISSION");

/// @notice The ENS subdomain registrar registering the DAO subdomains.
/// ! removed keeping it for storage layout compatibility
/// ! removed, but keeping it for storage layout compatibility
ENSSubdomainRegistrar public subdomainRegistrar;

/// @notice Emitted when a new DAO is registered.
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ contract PluginRepoRegistry is InterfaceBasedRegistry, ProtocolVersion {
keccak256("REGISTER_PLUGIN_REPO_PERMISSION");

/// @notice The ENS subdomain registrar registering the PluginRepo subdomains.
/// ! removed keeping it for storage layout compatibility
/// ! removed, but keeping it for storage layout compatibility
ENSSubdomainRegistrar public subdomainRegistrar;

/// @notice Emitted if a new plugin repository is registered.