Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add multisig client #127

Merged
merged 12 commits into from
Jan 13, 2023
Merged

Feature: Add multisig client #127

merged 12 commits into from
Jan 13, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Dec 20, 2022 •
edited by jira bot
Loading

Description

Add multisig client for plugins multisig contract

Task: APP-1369

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

brickpop
brickpop reviewed Dec 20, 2022
View reviewed changes
modules/client/examples/03-encoders/11-add-multisig-members.ts Outdated Show resolved Hide resolved
modules/client/examples/04-decoders/15-add-multisig-members.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/00-installation.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/04-approve-proposal.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/05-can-approve.ts Outdated Show resolved Hide resolved
modules/client/src/multisig/interfaces.ts Outdated Show resolved Hide resolved
modules/client/src/multisig/internal/constants.ts Outdated Show resolved Hide resolved
modules/client/test/helpers/deployContracts.ts Outdated Show resolved Hide resolved
modules/client/test/helpers/deployContracts.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@josemarinas josemarinas changed the base branch from develop to merge_all December 22, 2022 10:51
brickpop
brickpop reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@brickpop brickpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next round

modules/client/examples.md Outdated Show resolved Hide resolved
modules/client/examples.md Show resolved Hide resolved
modules/client/examples/03-encoders/11-add-multisig-addresses.ts Outdated Show resolved Hide resolved
modules/client/examples/04-decoders/15-add-multisig-addresses.ts Outdated Show resolved Hide resolved
modules/client/examples/04-decoders/16-remove-multisig-addresses copy.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/00-installation.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/07-can-execute.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/08-get-plugin-settings.ts Show resolved Hide resolved
modules/client/examples/06-multisig-client/10-get-proposals.ts Outdated Show resolved Hide resolved
modules/client/src/client-common/interfaces/plugin.ts Outdated Show resolved Hide resolved
brickpop
brickpop reviewed Dec 23, 2022
View reviewed changes
modules/client/examples/04-decoders/16-remove-multisig-addresses copy.ts Outdated Show resolved Hide resolved
modules/client/examples/04-decoders/16-remove-multisig-addresses copy.ts Outdated Show resolved Hide resolved
modules/client/examples/04-decoders/17-update-multisig-min-approvals.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/07-can-execute.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/07-can-execute.ts Outdated Show resolved Hide resolved
modules/client/examples/06-multisig-client/10-get-proposals.ts Outdated Show resolved Hide resolved
modules/client/src/client-common/interfaces/plugin.ts Outdated Show resolved Hide resolved
modules/client/src/client-common/utils.ts Outdated Show resolved Hide resolved
@josemarinas josemarinas changed the base branch from merge_all to develop January 11, 2023 09:47
@josemarinas josemarinas force-pushed the f/APP-1369-add-multisig-client branch from 57883af to 84198ac Compare January 12, 2023 09:19
brickpop
brickpop reviewed Jan 12, 2023
View reviewed changes
modules/client/examples.md Show resolved Hide resolved
modules/client/examples.md Outdated Show resolved Hide resolved
modules/client/examples.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@brickpop brickpop added the client-release Publishes the current version of client subpackage on NPM label Jan 13, 2023
@brickpop brickpop merged commit 4f6abf5 into develop Jan 13, 2023
@brickpop brickpop deleted the f/APP-1369-add-multisig-client branch January 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @brickpop