Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add voteReplacemeent flag and fix transfers and balances queries #155

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Feature: Add voteReplacemeent flag and fix transfers and balances queries #155

merged 11 commits into from
Feb 16, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Feb 15, 2023 •
edited by jira bot
Loading

Description

Add voteReplacemeent flag and fix transfers and balances queries

Task: APP-1760

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

brickpop
brickpop reviewed Feb 15, 2023
View reviewed changes
modules/client/examples.md Outdated Show resolved Hide resolved
modules/client/src/interfaces.ts Outdated Show resolved Hide resolved
modules/client/src/interfaces.ts Show resolved Hide resolved
modules/client/src/interfaces.ts Show resolved Hide resolved
modules/client/src/internal/graphql-queries/transfer.ts Outdated Show resolved Hide resolved
brickpop
brickpop reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@brickpop brickpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let's have a complete list of the breaking changes on the Changelog

modules/client/src/interfaces.ts Outdated Show resolved Hide resolved
modules/client/src/interfaces.ts Show resolved Hide resolved
modules/client/src/internal/client/methods.ts Outdated Show resolved Hide resolved
modules/client/test/integration/client/methods.test.ts Show resolved Hide resolved
brickpop
brickpop reviewed Feb 16, 2023
View reviewed changes
docs/client.md Show resolved Hide resolved
docs/client.md Show resolved Hide resolved
modules/client/examples.md Outdated Show resolved Hide resolved
modules/client/src/internal/client/methods.ts Outdated Show resolved Hide resolved
@josemarinas josemarinas added the client-release Publishes the current version of client subpackage on NPM label Feb 16, 2023
@josemarinas josemarinas force-pushed the f/APP-1760-adapt-transfers-querys branch from e1a1b5e to d866088 Compare February 16, 2023 18:06
@brickpop brickpop merged commit 6b9c859 into develop Feb 16, 2023
@brickpop brickpop deleted the f/APP-1760-adapt-transfers-querys branch February 16, 2023 18:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @brickpop