Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second layer of encryption #2

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Second layer of encryption #2

merged 6 commits into from
Apr 11, 2024

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Apr 4, 2024

After #1 is ready, this PR adds the upper layer to handle targeted symmetric key encryption for multiple actors

  • Encrypting metadata
  • Encrypting actions
  • Generating the list of encrypted symkeys
  • The corresponding decryption
  • E2E testing
  • Workflows

@brickpop brickpop requested review from carlosgj94 and xavikh April 4, 2024 15:34
Copy link
Contributor

@carlosgj94 carlosgj94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we can leave these three files here. But I agree that potentially this will become more of a generic feature and we might have to do it in a library/plugin of aragonette.

LGTM for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this helpers. They might look useless as most of them just call a function, but it's actually helpful the renamings.

@brickpop brickpop merged commit ecfbccf into main Apr 11, 2024
2 checks passed
@brickpop brickpop deleted the f/encryption-2 branch April 11, 2024 10:15
@brickpop brickpop mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants