Code

Feat/token voting target improvements#38

Code

Merged

novaknole merged 98 commits intodeveloparagon/token-voting-plugin:developfrom feat/token-voting-target-improvementsaragon/token-voting-plugin:feat/token-voting-target-improvementsCopy head branch name to clipboardNov 5, 2024

+2,585-414

Commits

Commits on Aug 26, 2024

• feat: update majority voting to support min approvals

  clauBv23

  committed
  c4605ea

  Copy full SHA for c4605ea

• ci: separate the updateMinApproval in a different function and add it to the majority vote base init function

  clauBv23

  committed
  5d955d8

  Copy full SHA for 5d955d8

• feat: add minApproval to token voting, duplicate init function to continue supporting old version

  clauBv23

  committed
  6a2456c

  Copy full SHA for 6a2456c

• fix: tests and compilation errors

  clauBv23

  committed
  bdba026

  Copy full SHA for bdba026

• feat: update the token voting setup so the min advance value in properly set when updating or installing

  clauBv23

  committed
  88f9d04

  Copy full SHA for 88f9d04

• fix: typo in the setup function selector

  clauBv23

  committed
  635b96c

  Copy full SHA for 635b96c

• feat: add new installation and update param in the build metadata file

  clauBv23

  committed
  42ef256

  Copy full SHA for 42ef256

• fix: update tests to work with new setup and configuration param

  clauBv23

  committed
  77f3d6f

  Copy full SHA for 77f3d6f

• feat: add natspec comments to the majority votes interface

  clauBv23

  committed
  0403d51

  Copy full SHA for 0403d51

• feat: add natspect comment to the token voting contract

  clauBv23

  committed
  902eb13

  Copy full SHA for 902eb13

• ci: remove not needed contract

  clauBv23

  committed
  7ec12c9

  Copy full SHA for 7ec12c9

• feat: add natspect and needed event when updating the min approval value

  clauBv23

  committed
  59165e4

  Copy full SHA for 59165e4

Commits on Aug 28, 2024

• feat: add test for checking the proposal can not be executed when the min approval is not reached

  clauBv23

  committed
  5d1c070

  Copy full SHA for 5d1c070

• feat: define new interfaces to check them on the tests

  clauBv23

  committed
  b6e9ca7

  Copy full SHA for b6e9ca7

• ci: move the min approval variable definition position

  clauBv23

  committed
  9b7394c

  Copy full SHA for 9b7394c

• fix: min approval values

  clauBv23

  committed
  04ca7fb

  Copy full SHA for 04ca7fb

• feat: add test for edge cases

  clauBv23

  committed
  8955f48

  Copy full SHA for 8955f48

• feat: modify the majority votes init function to receive the min approval

  clauBv23

  committed
  638ea07

  Copy full SHA for 638ea07

• feat: add tets for checking the updateMinApproval function

  clauBv23

  committed
  7ec2e54

  Copy full SHA for 7ec2e54

• ci: remove comment

  clauBv23

  committed
  e39d535

  Copy full SHA for e39d535

• feat: add test for old interfaces on majority votes

  clauBv23

  committed
  cb01be0

  Copy full SHA for cb01be0

• fix: import missing constant

  clauBv23

  committed
  f175112

  Copy full SHA for f175112

• feat: add validation for minimal approval value

  clauBv23

  committed
  a959426

  Copy full SHA for a959426

• fixL typos

  clauBv23

  committed
  c0bd627

  Copy full SHA for c0bd627

• feat: change test to the new initialize function

  clauBv23

  committed
  08409b5

  Copy full SHA for 08409b5

• feat: define the initialize function signature as constant to reuse it

  clauBv23

  committed
  9bc036a

  Copy full SHA for 9bc036a

• feat: revert on old initialize function

  clauBv23

  committed
  bb689ff

  Copy full SHA for bb689ff

• feat: use new constant signatures and add test to check deprecated intialize function reverts

  clauBv23

  committed
  119e15c

  Copy full SHA for 119e15c

• ci: improve natspec comment

  clauBv23

  committed
  7bf608b

  Copy full SHA for 7bf608b

• ci: remove comments

  clauBv23

  committed
  5c04b20

  Copy full SHA for 5c04b20

• ci: remove comment

  clauBv23

  committed
  6f7d789

  Copy full SHA for 6f7d789

• ci: comment

  clauBv23

  committed
  65198a0

  Copy full SHA for 65198a0

• fix: typo

  clauBv23

  committed
  8a69416

  Copy full SHA for 8a69416

• feat: rename min approval variable

  clauBv23

  committed
  af67a74

  Copy full SHA for af67a74

• fix: remove check no longer needed

  clauBv23

  committed
  939dac7

  Copy full SHA for 939dac7

• ci: refact

  clauBv23

  committed
  1219954

  Copy full SHA for 1219954

• ci: remove comment

  clauBv23

  committed
  210afb0

  Copy full SHA for 210afb0

Commits on Aug 29, 2024

• ci: add comment

  clauBv23

  committed
  fb95ba5

  Copy full SHA for fb95ba5

• fic: rename function for consistency

  clauBv23

  committed
  f7e0f97

  Copy full SHA for f7e0f97

• fix: update metadata description

  clauBv23

  committed
  345d6b7

  Copy full SHA for 345d6b7

• fix lint

  clauBv23

  committed
  4fe246c

  Copy full SHA for 4fe246c

• ci: rename all vars name

  clauBv23

  committed
  9b6cf85

  Copy full SHA for 9b6cf85

• ci: rename functions for consistency

  clauBv23

  committed
  92070c4

  Copy full SHA for 92070c4

• feat: change the min approval type from uint32 to uint256

  clauBv23

  committed
  4ce4388

  Copy full SHA for 4ce4388

• fix: test

  clauBv23

  committed
  c720fed

  Copy full SHA for c720fed

• fix test

  clauBv23

  committed
  1073c87

  Copy full SHA for 1073c87

Commits on Aug 30, 2024

• feat: add condition

  clauBv23

  committed
  cb368a3

  Copy full SHA for cb368a3

• feat: add new params to token voting

  clauBv23

  committed
  6173c49

  Copy full SHA for 6173c49

Commits on Sep 8, 2024

• add target configs permanently and fix tests

  novaknole

  committed
  7b44355

  Copy full SHA for 7b44355

Commits on Sep 10, 2024

• reinitializer number fixed and old interface

  novaknole

  committed
  5ce8060

  Copy full SHA for 5ce8060

• remove todo comments

  novaknole

  committed
  84ef2cd

  Copy full SHA for 84ef2cd

• initializeFrom with build number and data

  novaknole

  committed
  207d988

  Copy full SHA for 207d988

Commits on Sep 17, 2024

• ivotes checks

  novaknole

  committed
  5dfccfc

  Copy full SHA for 5dfccfc

Commits on Sep 19, 2024

• add initialization modifier for safety + improved targetconfig

  novaknole

  committed
  b2eef30

  Copy full SHA for b2eef30

• bytes param added

  novaknole

  committed
  96bf27b

  Copy full SHA for 96bf27b

• rename param function

  novaknole

  committed
  cd5543e

  Copy full SHA for cd5543e

Commits on Sep 25, 2024

• Update packages/contracts/src/TokenVoting.sol

  Show description for 42073e3
  

  novaknole

  and

  brickpop

  authored
  42073e3

  Copy full SHA for 42073e3

• Update packages/contracts/src/TokenVoting.sol

  Show description for 2051e27
  

  novaknole

  and

  brickpop

  authored
  2051e27

  Copy full SHA for 2051e27

• fix typo

  novaknole

  committed
  70f28e6

  Copy full SHA for 70f28e6

Commits on Sep 26, 2024

• add delegate call

  novaknole

  committed
  ccfe8ec

  Copy full SHA for ccfe8ec

• silence warnings

  novaknole

  committed
  f3cb27c

  Copy full SHA for f3cb27c

• add executor interface

  novaknole

  committed
  386d417

  Copy full SHA for 386d417

Commits on Sep 27, 2024

• action as free level

  novaknole

  committed
  329e76b

  Copy full SHA for 329e76b

• Merge pull request #34 from aragon/feature/executors

  Show description for 283c2c6
  novaknole

  authored
  283c2c6

  Copy full SHA for 283c2c6

• Merge pull request #32 from aragon/feature/bytes-param-add

  Show description for fba0116
  novaknole

  authored
  fba0116

  Copy full SHA for fba0116

• remove unneccessary revoke

  novaknole

  committed
  6b02e12

  Copy full SHA for 6b02e12

• Merge branch 'feat/token-voting-target-improvements' into feature/better-ivote-checks

  novaknole

  committed
  4a8be44

  Copy full SHA for 4a8be44

Commits on Sep 28, 2024

• Merge pull request #31 from aragon/feature/better-ivote-checks

  Show description for 41b5d7f
  novaknole

  authored
  41b5d7f

  Copy full SHA for 41b5d7f

• better upgrade tests

  novaknole

  committed
  93e6d31

  Copy full SHA for 93e6d31

• remove hardcoded value

  novaknole

  committed
  5178b67

  Copy full SHA for 5178b67

• Merge pull request #35 from aragon/feature/add-initializeFrom-upgrade-tests

  Show description for 4780717
  novaknole

  authored
  4780717

  Copy full SHA for 4780717

• callinitialization from osx-commons

  novaknole

  committed
  2690267

  Copy full SHA for 2690267

• Merge branch 'feat/token-voting-target-improvements' of https://github.com/aragon/token-voting-plugin into feat/token-voting-target-improvements

  novaknole

  committed
  630bfd9

  Copy full SHA for 630bfd9

Commits on Sep 29, 2024

• fix tohex

  novaknole

  committed
  0647d5d

  Copy full SHA for 0647d5d

Commits on Oct 8, 2024

• metadata extension

  novaknole

  committed
  4f86c7c

  Copy full SHA for 4f86c7c

• Update packages/contracts/src/MajorityVotingBase.sol

  Show description for f316675
  

  novaknole

  and

  brickpop

  authored
  f316675

  Copy full SHA for f316675

• Update packages/contracts/src/TokenVoting.sol

  Show description for ccfa5d9
  

  novaknole

  and

  brickpop

  authored
  ccfa5d9

  Copy full SHA for ccfa5d9

• Update packages/contracts/src/TokenVoting.sol

  Show description for d49093c
  

  novaknole

  and

  brickpop

  authored
  d49093c

  Copy full SHA for d49093c

• Update packages/contracts/src/TokenVoting.sol

  Show description for ab1af36
  

  novaknole

  and

  brickpop

  authored
  ab1af36

  Copy full SHA for ab1af36

• Update packages/contracts/src/TokenVotingSetup.sol

  Show description for 3176cd4
  

  novaknole

  and

  brickpop

  authored
  3176cd4

  Copy full SHA for 3176cd4

• Update packages/contracts/src/TokenVotingSetup.sol

  Show description for 3de9e37
  

  novaknole

  and

  brickpop

  authored
  3de9e37

  Copy full SHA for 3de9e37

• Update packages/contracts/src/TokenVotingSetup.sol

  Show description for 9799f4e
  

  novaknole

  and

  brickpop

  authored
  9799f4e

  Copy full SHA for 9799f4e

• permission added

  novaknole

  committed
  7b3d080

  Copy full SHA for 7b3d080

• Merge pull request #36 from aragon/feature/metadata

  Show description for ba6dcf8
  novaknole

  authored
  ba6dcf8

  Copy full SHA for ba6dcf8

Commits on Oct 9, 2024

• metadata rename

  novaknole

  committed
  4e5d291

  Copy full SHA for 4e5d291

Commits on Oct 14, 2024

• fix tests and contract (#37)

  Show description for a857d9e
  novaknole

  authored
  a857d9e

  Copy full SHA for a857d9e

Commits on Oct 25, 2024

• condition reorder

  novaknole

  committed
  8e9b423

  Copy full SHA for 8e9b423

Commits on Oct 31, 2024

• feat: add auth to execute() and update Setup & testing

  Rekard0

  committed
  f365fb5

  Copy full SHA for f365fb5

• add explicit test when auth revert without permission

  Rekard0

  committed
  9f4dbf2

  Copy full SHA for 9f4dbf2

• fix: fix comment

  Rekard0

  committed
  b1969cc

  Copy full SHA for b1969cc

• unused comments

  novaknole

  committed
  1f0faed

  Copy full SHA for 1f0faed

• add test for recording vote with tryEralyExecution when call don't have permission

  Rekard0

  committed
  75949c6

  Copy full SHA for 75949c6

Commits on Nov 1, 2024

• remove .only

  novaknole

  committed
  a5e7dca

  Copy full SHA for a5e7dca

• Merge pull request #39 from aragon/feature/add-auth-to-execute

  Show description for 427a7f5
  novaknole

  authored
  427a7f5

  Copy full SHA for 427a7f5

Commits on Nov 4, 2024

• hassucceeded

  novaknole

  committed
  e906746

  Copy full SHA for e906746

• reverts

  novaknole

  committed
  def23ed

  Copy full SHA for def23ed

• Merge pull request #40 from aragon/feature/hasSucceeded

  Show description for d86f894
  novaknole

  authored
  d86f894

  Copy full SHA for d86f894

Commits on Nov 5, 2024

• remove comment

  novaknole

  committed
  2a39ba9

  Copy full SHA for 2a39ba9