feat: hashi #1
Open
feat: hashi #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain in order to add hashi for cross chain communication
jordaniza
reviewed
Nov 25, 2024
| }); | ||
|
|
||
| emit ActionsRelayed(_callId, _params.dstEid, receipt); | ||
| uint256 _destinationChainId |
There was a problem hiding this comment.
To confirm my understanding of Hashi: the destinationChainId is it:
- The chainId for the specific protocol
- A chainId used by Hashi that reconciles to the specific chainId for the xchain protocol
| unchecked { | ||
| ++_nonce; | ||
| } | ||
| emit ActionsRelayed(_callId, _destinationChainId, commitment); |
There was a problem hiding this comment.
Should the nonce be in the event sig?
| @@ -0,0 +1,248 @@ | |||
| // SPDX-License-Identifier: LGPL-3.0-only | |||
| pragma solidity ^0.8.0; | |||
There was a problem hiding this comment.
This contract all looks good but I'd need to review in the context of how it fits in the wider application and the workflow. Would appreciate a walkthrough.
| uint256 chainId; // The ID of the blockchain where the proof is applicable. | ||
| uint256 blockNumber; // The block number at which the proof is generated. | ||
| bytes blockHeader; // The RLP-encoded header of the block containing the account state. | ||
| uint256 ancestralBlockNumber; // The block number of an ancestral block if needed for verification. |
There was a problem hiding this comment.
when are ancestral blocks required for verification and when are they not?
| */ | ||
| event ShoyuBashiSet(address shoyuBashi); | ||
|
|
||
| function __HashiProverUpgradeable_init(address shoyuBashi_) public onlyInitializing { |
There was a problem hiding this comment.
I believe you would define an init_unchained method to allow for inheritance. Not 100% necessary though
| /// @notice Emitted when ShoyuBashi is changed. | ||
| event ShoyuBashiSet(address shoyuBashi); | ||
|
|
||
| /// @notice Emitted when ShoyuBaactionRelayStorageKeyshi is changed. |
| /// @notice Metadata to identify a remote proposal. Logged on receipt. | ||
| /// @param callId The ID of the proposal on the foreign chain. No guarantees of uniqueness. | ||
| /// @param srcEid The LayerZero foreign chain ID. | ||
| /// @param srcChainid The LayerZero foreign chain ID. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.