Fix NextJS 15 issue with server side awaitable params and searchParams #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Looks good, thanks for this contribution @dimitribarbot snaps can help
|
@dimitribarbot pre-released in 3.0.0-canary.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I test if
props.paramsandprops.searchParamsarePromiseand if it is the case then I await them as defined in NextJS 15 documentation.Which issue (if any) does this pull request address?
This PR should answer issue #85.
Is there anything you'd like reviewers to focus on?
I'm not sure that the tests whether
props.paramsandprops.searchParamsarePromiseare necessary, as awaiting an object returns that object in javascript (I tested this in a browser though). Please tell me if you think I should remove them.