Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add next.js i18n routing support #285

Merged
merged 23 commits into from
Oct 29, 2020
Merged

Add next.js i18n routing support #285

merged 23 commits into from
Oct 29, 2020

Conversation

aralroca
Copy link
Owner

@aralroca aralroca commented Oct 27, 2020 •
edited
Loading

Closes #284
Closes #250
Closes #248
Closes #245
Closes #231
Closes #209
Closes #208
Closes #204
Closes #169

Released under 0.19.0-experimental.1 0.19.0-experimental.6

@aralroca aralroca self-assigned this Oct 27, 2020
@aralroca aralroca marked this pull request as ready for review October 28, 2020 00:00
@aralroca aralroca marked this pull request as draft October 28, 2020 00:00
@aralroca aralroca mentioned this pull request Oct 28, 2020
Closed
@aralroca aralroca marked this pull request as ready for review October 28, 2020 05:53
@aralroca aralroca mentioned this pull request Oct 28, 2020
Closed
@BjoernRave
Copy link
Contributor

Because I am using https://github.com/FormidableLabs/urql/tree/main/packages/next-urql, which uses getInitialProps under the hood to fetch data, I am getting the following error:

Error: You can not use getInitialProps with getStaticProps. To use SSG, please remove your getInitialProps

@aralroca
Copy link
Owner Author

Because I am using https://github.com/FormidableLabs/urql/tree/main/packages/next-urql, which uses getInitialProps under the hood to fetch data, I am getting the following error:

Error: You can not use getInitialProps with getStaticProps. To use SSG, please remove your getInitialProps

Thanks for the feedback @BjoernRave. I'm going to think about how I can solve this case. When the getInitialProps is done in another file different from the page it is a missing case. Well seen.

@BjoernRave

This comment has been minimized.

Sign in to view
@aralroca

This comment has been minimized.

Sign in to view
@aralroca
Copy link
Owner Author

aralroca commented Oct 28, 2020 •
edited
Loading

Prereleased 0.19.0-experimental.3 0.19.0-experimental.6 , @BjoernRave now it should use a getInitialProps, however now I found another bug related with getIntialProps: vercel/next.js#18396

@aralroca aralroca changed the base branch from canary to master October 29, 2020 10:39
@aralroca aralroca added this to the 0.19.0 milestone Oct 29, 2020
@aralroca aralroca merged commit 9e93a91 into master Oct 29, 2020
@aralroca aralroca deleted the i18n-routing branch October 29, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aralroca aralroca

Labels
None yet
Projects
None yet
Milestone
0.19.0
2 participants
@aralroca @BjoernRave