Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add:Support MySQL CHAR_LENGTH function.#501 #544

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

gongna-au
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #501

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 36.53% // Head: 36.55% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b71e2e4) compared to base (a545ceb).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   36.53%   36.55%   +0.02%     
==========================================
  Files         167      170       +3     
  Lines       21716    21785      +69     
==========================================
+ Hits         7934     7964      +30     
- Misses      12914    12951      +37     
- Partials      868      870       +2     
Impacted Files Coverage Δ
pkg/runtime/function/char_length.go 72.72% <72.72%> (ø)
pkg/config/tenant.go 0.00% <0.00%> (ø)
pkg/config/misc.go 0.00% <0.00%> (ø)
pkg/runtime/function/repeat.go 70.37% <0.00%> (ø)
pkg/schema/loader.go 6.74% <0.00%> (+1.12%) ⬆️
pkg/boot/discovery.go 48.62% <0.00%> (+2.16%) ⬆️
pkg/config/file/file.go 73.68% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Nov 22, 2022
@dongzl dongzl added this to the 0.2.0 milestone Nov 22, 2022
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit f2dfe76 into arana-db:master Nov 25, 2022
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
* Add:Support MySQL CHAR_LENGTH function.arana-db#501

* Add:Support MySQL CHAR_LENGTH function.arana-db#501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL CHAR_LENGTH function.
5 participants