Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow having one operator for all namespaces #551

Closed
wants to merge 4 commits into from

Conversation

couds
Copy link

@couds couds commented Apr 14, 2020

This commit change the behavior of the operator to listen to all namespaces for the custom resources.

Before this commit you needed to install the deployment operator on each namespace you wanted to create a ArangoDeployment

@ajanikow ajanikow self-assigned this Apr 14, 2020
@ajanikow
Copy link
Collaborator

Hello!

We do not want to change default action taken by Operator - so it should be binded to namespace by default. We have security and lifecycle reasons to act like this - on kubernetes with multiple ArangoDB Deployments we can maintain multiple stages (prod, staging, dev) and upgrade them one by one. We are also sure that one broken Operator wont destroy other installation (RBAC).

If you need support like this then it should be implemented in generic way without changes in current default logic. You can add helm flag for mode, and based on this mode generate proper RBAC and deployment configs.

Best Regards,
Adam.

Copy link
Collaborator

@ajanikow ajanikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change in comment

@rizzaricreative
Copy link

@ajanikow It seem like you are holding up the approval process with this change. This pr is waiting for you to review.

For most of us, a namespaced locked operator does not make sense neither does deploying it to multiple namespaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants