-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Traditional Chinese(zhTW) locale #1042
Conversation
@PeterDaveHello is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
@dartpain can you also help review this one? Thanks. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Perfect @PeterDaveHello, |
0ed422a
to
ed5db76
Compare
@ManishMadan2882 done 👍 |
Hey there is a build log issue [20:05:35.939] Running build in Washington, D.C., USA (East) – iad1 |
@ManishMadan2882 is there anything I should do here? |
Hi @PeterDaveHello |
ed5db76
to
9b8d97b
Compare
9b8d97b
to
46e9f0d
Compare
src/locale/i18n.ts(9,10): error TS1005: '=' expected. Still getting this error |
It looks like because the hyphen Should we rename the variable like this: import zhTW from './zh-TW.json'; // Traditional Chinese And then adjust the usage accordingly: "zh-TW": {
translation: zhTW,
}, |
@PeterDaveHello yes please, this should fix the syntax. |
46e9f0d
to
8bcf7bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PeterDaveHello
@holopin-bot @PeterDaveHello Thank you! |
Congratulations @PeterDaveHello, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jemjx900620cm8p2gj20no This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Hey @PeterDaveHello fill in this form if you are interested in a t-shirt |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add Traditional Chinese(zhTW) locale
Why was this change needed? (You can also link to an open issue here)
More language support, more users approach
Other information:
None