-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature n/lancedb #1122
Feature n/lancedb #1122
Conversation
@akashAD98 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dartpain i added this pr & checked all implementation in local its working fine would be great if you can merge it . thank you |
@dartpain would be great if you could check & merge the pr .thank you |
@ManishMadan2882 can you please check this pr? |
Hi, I seem to have an issue running it. I added " |
same changes i .did & i runned & its giving me output /DocsGPT$ ./run-with-docker-compose.sh is their any other way to do it test it? what error your getting
|
@dartpain hi sir this pr is pending for 3 weeks.can you check it please? |
@akashAD98
check out this file https://github.com/arc53/DocsGPT/blob/main/application/parser/open_ai_func.py
Most issues should be easy to fix. |
Hi @dartpain , I'm from LanceDB team. Just came across this PR. Could you please elaborate on point 3, as to why Lance wont work with docker? As for in-memory mode, LanceDB is persisted in storage rather than memory, so it doesn't need to load/create vector indices in memory. Let me know if you're seeing any weird behaviours |
@dartpain any update on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much, sorry for delays, had to test things
@holopin-bot @akashAD98 Thank you! |
@holopin-bot @akashAD98 Thank you! |
Congratulations @akashAD98, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qd81x73040clb2f38ca7t This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Hey @akashAD98 please fill in this form if you are interested in a t-shirt |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added support for lancedb as vectordb
Other information:
I have already created pr but there are a few things missing so I created a new pr
also, I tested it & it's working now with Lancedb