Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Attractive Skeleton Loader Component is added [Fixes #1181] #1188

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

prathamesh424
Copy link
Contributor

@prathamesh424 prathamesh424 commented Oct 1, 2024

Added Reuable Loader component [Fixes #1181 ]

Screen.Recording.2024-10-04.233837.mp4
Screen.Recording.2024-10-04.234152.mp4

Copy link

vercel bot commented Oct 1, 2024

@prathamesh424 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@prathamesh424
Copy link
Contributor Author

for hacktoberfest and devfest

@prathamesh424 prathamesh424 changed the title Reusable Attractive Loader Component is added #1181 Reusable Attractive Loader Component is added [Fixes #1181] Oct 2, 2024
@dartpain
Copy link
Contributor

dartpain commented Oct 4, 2024

Please make sure you use skeleton loader, similarly to what we have in the sources
CleanShot 2024-10-04 at 18 05 10@2x
CleanShot 2024-10-04 at 18 05 43

@prathamesh424
Copy link
Contributor Author

@dartpain you can check now added skeleton loader

call the function count represent the number of cards

dark theme :

Screen.Recording.2024-10-04.234152.mp4

light theme:

Screen.Recording.2024-10-04.233837.mp4

@prathamesh424 prathamesh424 changed the title Reusable Attractive Loader Component is added [Fixes #1181] Reusable Attractive Skeleton Loader Component is added [Fixes #1181] Oct 4, 2024
@dartpain
Copy link
Contributor

dartpain commented Oct 5, 2024

I think as part of the issue we need to use this component now in
Component can be integrated in Settings > Documents, Chatbots, Analytics, logs

During the loading state as per the issue.

Thank you!

@prathamesh424
Copy link
Contributor Author

prathamesh424 commented Oct 6, 2024

@dartpain

Updated the loading state and loader in the settings component :

Screenshot 2024-10-06 110355
Screenshot 2024-10-06 110859
Screenshot 2024-10-06 110914
Screenshot 2024-10-06 111143
Screenshot 2024-10-06 105221

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2024

Can we make this skeleton thing more responsive to the size of the window?
Such that if its a large window ( as we have in settings) we dont show multiple skeleton tabs, but one large for example.
Here is a good rundown:
https://www.nngroup.com/articles/skeleton-screens/

Thank you!

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 4:29pm

@github-actions github-actions bot added the repo label Oct 7, 2024
@tenokami
Copy link
Collaborator

@prathamesh424 Can you upload videos to see how it looks animated?

@tenokami
Copy link
Collaborator

tenokami commented Oct 10, 2024

@prathamesh424 On the Chatbots tab we will have a table that will look like here #1286

So skeleton should match it to some extent

@prathamesh424
Copy link
Contributor Author

prathamesh424 commented Oct 10, 2024

@dartpain sir check out preview :

Screen.Recording.2024-10-10.205831.mp4

@prathamesh424
Copy link
Contributor Author

please add the hactoberfest-accepted tag while merging

@prathamesh424
Copy link
Contributor Author

prathamesh424 commented Oct 11, 2024

@dartpain and @tenokami can you check out final loader design after all update

@tenokami
Copy link
Collaborator

@dartpain Might be passable for the first version?

@prathamesh424
Copy link
Contributor Author

@ManishMadan2882 can check out the pull request ... under hacktoberfest and devfest

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prathamesh424
Thanks for an update, just reviewed the PR, have few points:

  • The loader looks good and reasonably placed.
  • Would be better to locate it in src/components instead of src/utils dir, please name the file as SkeletonLoader.tsx.
  • Also, could you please sync the file with the upstream main, as there are merge conflicts.

@prathamesh424
Copy link
Contributor Author

@ManishMadan2882 check out now I solved the conflicts

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks @prathamesh424 !

@dartpain dartpain merged commit 9be3043 into arc53:main Oct 15, 2024
5 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @prathamesh424 Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @prathamesh424, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jeozq409460cm8mnza0ui7

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

Hey @prathamesh424 please fill in this form if you are interested in a t-shirt
https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Creating a reusable loader for all the tabs while fetching responses.
4 participants