-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable Attractive Skeleton Loader Component is added [Fixes #1181] #1188
Conversation
@prathamesh424 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
for hacktoberfest and devfest |
@dartpain you can check now added skeleton loadercall the function count represent the number of cards dark theme : Screen.Recording.2024-10-04.234152.mp4light theme: Screen.Recording.2024-10-04.233837.mp4 |
I think as part of the issue we need to use this component now in During the loading state as per the issue. Thank you! |
Updated the loading state and loader in the settings component : |
Can we make this skeleton thing more responsive to the size of the window? Thank you! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@prathamesh424 Can you upload videos to see how it looks animated? |
@prathamesh424 On the Chatbots tab we will have a table that will look like here #1286 So skeleton should match it to some extent |
@dartpain sir check out preview : Screen.Recording.2024-10-10.205831.mp4 |
please add the hactoberfest-accepted tag while merging |
@dartpain Might be passable for the first version? |
@ManishMadan2882 can check out the pull request ... under hacktoberfest and devfest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prathamesh424
Thanks for an update, just reviewed the PR, have few points:
- The loader looks good and reasonably placed.
- Would be better to locate it in src/components instead of src/utils dir, please name the file as SkeletonLoader.tsx.
- Also, could you please sync the file with the upstream main, as there are merge conflicts.
@ManishMadan2882 check out now I solved the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks @prathamesh424 !
@holopin-bot @prathamesh424 Thank you! |
Congratulations @prathamesh424, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jeozq409460cm8mnza0ui7 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Hey @prathamesh424 please fill in this form if you are interested in a t-shirt |
Added Reuable Loader component [Fixes #1181 ]
Screen.Recording.2024-10-04.233837.mp4
Screen.Recording.2024-10-04.234152.mp4