Replacing About with a Help dropdown that has contact and documentati…

[sccalabr]

Creating a dropdown that will replace about with email and documentation. Fixes #1204

[vercel]

@sccalabr is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

[sccalabr]

Let me know if this is what you had in mind

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-gpt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 4:38pm

[dartpain]

Thank you so much I have a few comments:

1. About button should be replace with help, not a new button above
   
   Also the icon is good.
2. Please re-use existing dropdown component

[sccalabr]

[dartpain]

Thank you so much!

There seems to be an error

src/Navigation.tsx(336,16): error TS2741: Property 'selectedValue' is missing in type '{ placeholder: string; contentSize: string; options: { label: string; value: string; }[]; onSelect: (selectedOption: any) => void; }' but required in type '{ options: string[] | { name: string; id: string; type: string; }[] | { label: string; value: string; }[] | { value: number; description: string; }[]; selectedValue: string | { label: string; value: string; } | { ...; } | { ...; } | null; ... 10 more ...; contentSize?: string | undefined; }'.
src/Navigation.tsx(340,28): error TS7006: Parameter 'selectedOption' implicitly has an 'any' type.
src/components/Dropdown.tsx(101,40): error TS2322: Type 'string | { label: string; value: string; } | { value: number; description: string; } | { name: string; id: string; type: string; }' is not assignable to type 'object'.
  Type 'string' is not assignable to type 'object'.
src/components/Dropdown.tsx(109,55): error TS2339: Property 'top' does not exist on type '{}'.
Error: Command "npm run build" exited with 2

Try to use npm run build before pushing

[sccalabr]

Thank you so much!

There seems to be an error

src/Navigation.tsx(336,16): error TS2741: Property 'selectedValue' is missing in type '{ placeholder: string; contentSize: string; options: { label: string; value: string; }[]; onSelect: (selectedOption: any) => void; }' but required in type '{ options: string[] | { name: string; id: string; type: string; }[] | { label: string; value: string; }[] | { value: number; description: string; }[]; selectedValue: string | { label: string; value: string; } | { ...; } | { ...; } | null; ... 10 more ...; contentSize?: string | undefined; }'.
src/Navigation.tsx(340,28): error TS7006: Parameter 'selectedOption' implicitly has an 'any' type.
src/components/Dropdown.tsx(101,40): error TS2322: Type 'string | { label: string; value: string; } | { value: number; description: string; } | { name: string; id: string; type: string; }' is not assignable to type 'object'.
  Type 'string' is not assignable to type 'object'.
src/components/Dropdown.tsx(109,55): error TS2339: Property 'top' does not exist on type '{}'.
Error: Command "npm run build" exited with 2

Try to use npm run build before pushing

When I try running that locally I get

npm run
build
npm ERR! Missing script: "build"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR! npm run

[dartpain]

Which directory are you running it from?
Make sure its frontend/
Also make sure you install npm dependencies there

[sccalabr]

synced

[ManishMadan2882]

@sccalabr Have few points:

• Try to make the hover effect cover the whole block as in the design
  
• The Help section needs little bit vertical padding (py-1) to make it consistent.
  

[sccalabr]

Like this?
/

[ManishMadan2882]

Thanks for the update @sccalabr .
Could you please run npm run lint-fix and push once.
Looks good but there are certain linting errors.

[sccalabr]

I dont see any linting errors locally and it says my branch is upto date. Manually fixed something I saw though

[ManishMadan2882]

LGTM @sccalabr
Thanks!

[dartpain]

Hey @sccalabr as per design that section should look like this

Please check out our figma
https://www.figma.com/design/OXLtrl1EAy885to6S69554/DocsGPT?node-id=867-534&node-type=frame&t=LIBlsvZCmEkEH3xn-0
We are almost there, I think we need to change positioning a little and inceease height to match other buttons

[sccalabr]

What should the values be for the positioning and heights? It looks pretty much the same to me

[ManishMadan2882]

Thanks for the update @sccalabr !

[sccalabr]

Is there anything else I need to do?

[sccalabr]

@dartpain Is there anything I need to do to get the holopin or will that come at the end of the month?

[dartpain]

@holopin-bot @sccalabr Thank you!

[holopin-bot]

Congratulations @sccalabr, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jeo0ph04120clawxfvy0a0

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!