Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of mobile retry button #1235

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

ovindu-a
Copy link
Contributor

@ovindu-a ovindu-a commented Oct 4, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR changes the size of the retry button when on mobile and also hides the "Retry" text so the UI looks more viewable.

  • Why was this change needed? (You can also link to an open issue here)

This was to fix issue #1230 where the retry button being too big in mobile view

  • Other information:
image

Initial change makes it look like this. If this way of approaching is fine can edit the styles for it to make it look better.

Copy link

vercel bot commented Oct 4, 2024

@ovindu-a is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@ManishMadan2882
Copy link
Collaborator

Hi @ovindu-a
It would be better to have a small regenerate icon instead of the Copy button in case of error, think it will look better on other devices as well.

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 7, 2024

@ManishMadan2882 thank you. That seems like a good idea, shall I implement something like that? @dartpain

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2024

Yep, that would be great, thank you!

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 7, 2024

Will do.

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 7, 2024

image

How does this look? @dartpain

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2024

Think this looks great!

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:29am

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 8, 2024

@dartpain I have made the changes in the newest commit. Please let me know if there is anything to be changed.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ovindu-a
In case of no error, there is an empty space because of hidden retry icon, would suggest to conditionally render.
image
Thanks!

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 9, 2024

@ManishMadan2882 I have made the requested change, please let me know if this is alright

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ovindu-a !

@dartpain dartpain merged commit 09537ec into arc53:main Oct 9, 2024
6 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @ovindu-a Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @ovindu-a, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jen0bq03030cl89wj30pme

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

Hey @ovindu-a please fill in this form if you are interested in a t-shirt
https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

@ovindu-a
Copy link
Contributor Author

Oh that's cool @dartpain. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants