-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting of mobile retry button #1235
Conversation
@ovindu-a is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Hi @ovindu-a |
@ManishMadan2882 thank you. That seems like a good idea, shall I implement something like that? @dartpain |
Yep, that would be great, thank you! |
Will do. |
How does this look? @dartpain |
Think this looks great! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dartpain I have made the changes in the newest commit. Please let me know if there is anything to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ovindu-a
In case of no error, there is an empty space because of hidden retry icon, would suggest to conditionally render.
Thanks!
@ManishMadan2882 I have made the requested change, please let me know if this is alright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ovindu-a !
@holopin-bot @ovindu-a Thank you! |
Congratulations @ovindu-a, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jen0bq03030cl89wj30pme This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Hey @ovindu-a please fill in this form if you are interested in a t-shirt |
Oh that's cool @dartpain. Thank you |
This PR changes the size of the retry button when on mobile and also hides the "Retry" text so the UI looks more viewable.
This was to fix issue #1230 where the retry button being too big in mobile view
Initial change makes it look like this. If this way of approaching is fine can edit the styles for it to make it look better.