Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logo clickable #1242

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Make logo clickable #1242

merged 2 commits into from
Oct 6, 2024

Conversation

Piyush-Tilokani
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Solves issue 🚀 Feature: Make logo clickable #1221
    Made the logo clickable to improve the overall user experience

  • Why was this change needed? (You can also link to an open issue here)
    It is a common practice to make the logo click redirect to an index page. as stated in 🚀 Feature: Make logo clickable #1221

  • Other information:
    NA

@pabik please review and merge this PR

Copy link

vercel bot commented Oct 5, 2024

@Piyush-Tilokani is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 11:01pm

@dartpain
Copy link
Contributor

dartpain commented Oct 6, 2024

Think the positioning is changed a bit now. Should have a bit more of a Gap as per the figma design.

Thank you!

@Piyush-Tilokani
Copy link
Contributor Author

Think the positioning is changed a bit now. Should have a bit more of a Gap as per the figma design.

Thank you!

Adjusted the positioning in the latest commit
The gap is now the same as it previously was

@ManishMadan2882 ManishMadan2882 self-requested a review October 6, 2024 19:19
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Piyush-Tilokani !

@dartpain dartpain merged commit 4632531 into arc53:main Oct 6, 2024
3 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @Piyush-Tilokani Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @Piyush-Tilokani, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jekhfg10020cjvb6yvy9rb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

Hey @Piyush-Tilokani please fill in this form if you are interested in a t-shirt
https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants