Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed @vercel/analytics from frontend #1243

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

ayaan-qadri
Copy link
Contributor

Removed @vercel/analytics from frontend due to being flagged by AdBlocker, causing rendering issues in the development.
(It is not affecting in Cloud version, neither in build)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

    • Uninstalled @vercel/analytics from the frontend only also removed importing statement of inject and calling it.
  • Why was this change needed? (You can also link to an open issue here)

    • It was affecting rendering and no error in the console (check the Screenshots) if the AdBlocker extension is enabled, but it starts rendering if you disable it, so if someone is not aware of might be time taking process and check for various setup if it is problem with that.
  • Other information:
    norendering
    consolemsges

Copy link

vercel bot commented Oct 5, 2024

@ayaan-qadri is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dartpain dartpain merged commit 4895d38 into arc53:main Oct 6, 2024
2 of 3 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @ayaan-qadri Thank you!

@dartpain
Copy link
Contributor

dartpain commented Nov 8, 2024

@holopin-bot @ayaan-qadri Thank you!

Copy link

holopin-bot bot commented Nov 8, 2024

Congratulations @ayaan-qadri, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qizxx47660cjx0bul4v91

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@ayaan-qadri
Copy link
Contributor Author

Thank you @dartpain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants