Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload #1274

Merged
merged 6 commits into from
Oct 10, 2024
Merged

fix upload #1274

merged 6 commits into from
Oct 10, 2024

Conversation

rohittcodes
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR updates the previous upload component with a modal for uploading with 2 buttons separately.

  • Why was this change needed? (You can also link to an open issue here)
    This change fixes 🚀 Feature: Updated UI/UX for "Upload new document" modal #1210, by introducing certain components as required for the UI upgrade.

  • Other information:

video ref

docsgpt.mp4

Copy link

vercel bot commented Oct 8, 2024

@rohittcodes is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rohittcodes
Overall, it looks great, but I noticed a minor change.
Could you please make sure that the colour code in the buttons match the design
Thank you!

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:03pm

@rohittcodes
Copy link
Contributor Author

@ManishMadan2882 I've fixed the colors in the button as per the required design for the node you've shared, and updated the gap between train and back button as I forgot about that while the first commit. Can you've a look please?

@ManishMadan2882
Copy link
Collaborator

ManishMadan2882 commented Oct 9, 2024

Hi @rohittcodes
Thanks for an update, just reviewed.
Could you please update the colour for the 'Please wait' text (in Progress) to white.

@rohittcodes
Copy link
Contributor Author

@ManishMadan2882 updated!

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @rohittcodes
Thank you !

@dartpain dartpain merged commit 5bfd7d5 into arc53:main Oct 10, 2024
6 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @rohittcodes Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @rohittcodes, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jen9u003610cl80fwt4q9x

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Updated UI/UX for "Upload new document" modal
3 participants