-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix upload #1274
fix upload #1274
Conversation
@rohittcodes is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rohittcodes
Overall, it looks great, but I noticed a minor change.
Could you please make sure that the colour code in the buttons match the design
Thank you!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ManishMadan2882 I've fixed the colors in the button as per the required design for the node you've shared, and updated the gap between train and back button as I forgot about that while the first commit. Can you've a look please? |
Hi @rohittcodes |
@ManishMadan2882 updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect @rohittcodes
Thank you !
@holopin-bot @rohittcodes Thank you! |
Congratulations @rohittcodes, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jen9u003610cl80fwt4q9x This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR updates the previous upload component with a modal for uploading with 2 buttons separately.
Why was this change needed? (You can also link to an open issue here)
This change fixes 🚀 Feature: Updated UI/UX for "Upload new document" modal #1210, by introducing certain components as required for the UI upgrade.
Other information:
video ref
docsgpt.mp4