Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(273): CI enable images tagging #1278

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

anasKhafaga
Copy link
Contributor

@anasKhafaga anasKhafaga commented Oct 8, 2024

  • What kind of change does this PR introduce?
    This PR introduces a feature update related to Add release tags to docker images published to docker hub #273. It updates the GitHub workflows to build and push Docker images, including changes in the ci.yml, cife.yml files, and adds new workflows (docker-develop-build.yml and docker-develop-fe-build.yml) to support development builds.

  • Why was this change needed?
    The changes were needed to streamline the CI/CD pipeline for DocsGPT, enabling the release-based tagging and pushing of Docker images. This also adds support for development builds of both the main DocsGPT application and the frontend, ensuring that images can be built in between releases under develop tag and pushed to Docker Hub and GitHub Container Registry (GHCR). This allows for better management of both release and development builds.

  • Other information:

    • Introduced caching mechanisms (cache-from and cache-to) for Docker images to optimize build times.

      image
      Here's a test conducted to show build duration after the initial build.

    • The workflows now trigger on the release event for published releases, ensuring that the correct version tags are applied to Docker images.

    • The newly added docker-develop-build.yml and docker-develop-fe-build.yml workflows ensure that development images are pushed when changes are made to the main branch.

Warning

Whenever a push to the main branch occurs, it triggers an image build, and the image name has been updated to {{imageName}}:develop instead of {{imageName}}:latest, so please update any pipeline that depends on the old image tag to use the new one.

Copy link

vercel bot commented Oct 8, 2024

@anasKhafaga is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@anasKhafaga
Copy link
Contributor Author

cc: @dartpain

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
Like the change with a dev tag and now a "stable" latest
Appreciate it

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:26pm

@dartpain dartpain merged commit 862ea5f into arc53:main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants