Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved / #1294 #1306

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Solved / #1294 #1306

merged 3 commits into from
Oct 15, 2024

Conversation

ayaan-qadri
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  1. Resolves 🐛 Bug Report: Disable scrolling and Close popup box clicking on three dots #1294
  2. Disabled scrolling when popup is opened
  3. Now you can close (when popup us open) popup by clicking on again three dots
  • Why was this change needed? (You can also link to an open issue here)
    Provide a better experience and remove unevenness in the UI.

  • Other information:
    -

Copy link

vercel bot commented Oct 11, 2024

@ayaan-qadri is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@ManishMadan2882
Copy link
Collaborator

@ayaan-qadri Just reviewed, feels like the scroll bar toggles on clicking the menu, which makes it look inconsistent.
Can you please try some workaround to improve this?
Thanks!

closed
open

@ayaan-qadri
Copy link
Contributor Author

Just reviewed, feels like the scroll bar toggles on clicking the menu, which makes it look inconsistent

@ManishMadan2882 , Do you want to remove the scrollbar when it's enabled, or am I misunderstanding?

@dartpain
Copy link
Contributor

I thin Manish suggests not to remove scrollbar when its enabled, such that its visible

@ayaan-qadri
Copy link
Contributor Author

I thin Manish suggests not to remove scrollbar when its enabled, such that its visible

If this is the case, then it should be as it is now because when you pop up, we do not allow scrolling. If the scrollbar still appears, it suggests that the portion is scrollable, which it is not. let me know if you want that apperience.

@ayaan-qadri
Copy link
Contributor Author

@ManishMadan2882, I have made changes as per your request, let me know further if there are any changes that should be made.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:07am

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @ayaan-qadri , Thanks !

@dartpain dartpain merged commit 42185a0 into arc53:main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Disable scrolling and Close popup box clicking on three dots
4 participants