Fixes - 1292

[Niharika0104]

Fixes #1292

Made UI/UX changes.

[vercel]

@Niharika0104 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-gpt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 21, 2024 1:44pm

[ManishMadan2882]

Hi @Niharika0104
Thanks for the update, just reviewed.
The New Chat Icon is visible on the chat with no conversations in desktop screen.
Also, could you please sync your branch with the upstream main.

[Niharika0104]

@ManishMadan2882
I incorporated the requested changes and also updated the branch with upstream branch

[ManishMadan2882]

Hi @Niharika0104
I closely monitored the Redux States, and found that there is one case which will need improvement:
Try clicking the new chat button while one Conversation is streaming.
Noticed that the queries are emptied at this point,status is set to idle but the conversationId is not set to null.
Could you please look into this case and submit a fix.
Thanks!

[Niharika0104]

@ManishMadan2882 I'm not clear with your exact ask
when some conversation is loading(loading icon in the input box) and during that time if user clicks on new Chat button then conversation id should be set to null but it is not happening
Is it what you are asking me or did i get wrong?

[ManishMadan2882]

Exactly @Niharika0104

[Niharika0104]

@ManishMadan2882

I see the similar issue even when i click on the new chat button in the navbar panel
So the issue is already there from the beginning right ?

[ManishMadan2882]

@ManishMadan2882 I see the similar issue even when i click on the new chat button in the navbar panel So the issue is already there from the beginning right ?

Yes, I think the resetConversation() method might be where the problem occurs, however it's not there on the production.

[Niharika0104]

@ManishMadan2882 I observed this thing when we click on new chat and see a blank conversation page ( as you said we still see that conversationid is not null ) its same as the previous one ,however as soon as we give some query in that blank conversation page i see the we have a new conversationid and this is fine i guess
and as long as conversationId is getting updated we shouldn't be having any issues.Or do you have any other thoughts on this one?

[Niharika0104]

I just mistakenly clicked on close with comment

[ManishMadan2882]

I think the conversationId should be null as we move to a fresh conversation, because there are few things dependent on this functionality, Like the selection in the sidebar is not updated, the Share icon shouldn't be there for a null ConversationID.
So, yeah it is necessary that the conversationId should be null in any case we move to a new chat.

You can see in this screenshot that the Share icon on top right, the sidebar selection are inconsistent, think it should require a minor fix.

[Niharika0104]

@ManishMadan2882 are you saying that when we click on a particular conversation slice we are unable to load the queries present in those conversation id on the conversation screen?

[ManishMadan2882]

No, you can reproduce the issue by these steps:

• Prompt the conversation
• By the time the conversation loads, click the New Chat (it is still loading/streaming)
• When you come to new chat, you will notice that the:
  - ConversationId hasn't updated although the queries are emptied
  - The Share button is still visible as it is rendered where the conversationId is not null
  - The sidebar is not getting updated, because the conversationId is not updated
  The conversationId is not updated to null only the queries have been emptied which is the problem.

[Niharika0104]

@ManishMadan2882 Can you check it now?
The issue is resolved now.

[ManishMadan2882]

Looks Good, Thanks @Niharika0104 !

[dartpain]

@holopin-bot @Niharika0104 Thank you!

[holopin-bot]

Congratulations @Niharika0104, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jequub15600cm81iiiu7xk

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!