-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Added loading state for conversation list #1343
Enhancement: Added loading state for conversation list #1343
Conversation
@JeevaRamanathan is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Can you please provide some screenshots, thank you! |
Hi @dartpain, in the Expected behavior of this issue #1342 (comment) I have added the demo video. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
- Coverage 34.15% 33.45% -0.71%
==========================================
Files 63 64 +1
Lines 3200 3273 +73
==========================================
+ Hits 1093 1095 +2
- Misses 2107 2178 +71 ☔ View full report in Codecov by Sentry. |
Really appreciate it, thank you
|
@dartpain @JeevaRamanathan I'd suggest moving loader to the middle/center and all good |
Signed-off-by: JeevaRamanathan M <[email protected]>
Hi,
23.10.2024_04.02.02_REC.mp4 |
@JeevaRamanathan Frankly, that's not ideal... |
@tenokami the loader will not display if it's delete conversation. Does this align? 23.10.2024_04.39.45_REC.mp4 |
Signed-off-by: JeevaRamanathan M <[email protected]>
@JeevaRamanathan yes! thx |
Hi @dartpain, it's ready now after the changes |
Hi @ManishMadan2882, could you please have a look into this based on your time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @JeevaRamanathan !
Bug fix / enhancement
There is no indication that the conversations are fetching in sidebar. Added a loader state and icon to indicate it's loading. Resolves 🐛 Bug Report: Enhancement - Add Loader Icon for Fetching List of Conversations #1342
Without introducing separate variable I have just extended the conversations object. Please let me know if you suggest any other alternative approaches as well.