Bug fix: /api/share route #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Steps to reproduce this bug:
1. Create a conversation
2. Create a shared link for the conversation, with enable allow users to prompt further
3. Create another shared link for the conversation, this time disable the option to prompt further
Current behaviour: The same uuid is assigned to both the shared conversations
Expected behaviour: A shared conversation which is promptable with a particular doc should be unique avoiding redundant entries; while a non-promptable shared conversation should also be unique but distinct from a promptable one
Why was this change needed? (You can also link to an open issue here)
Avoids ambiguity in the behaviour of shared conversations.