Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSON Parser Implementation #1377

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

JeevaRamanathan
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature
  • Why was this change needed? (You can also link to an open issue here)
    Implemented a JSONParser for interacting with .json files.
  • Other information:
jsonparse.mp4

Signed-off-by: JeevaRamanathan M <[email protected]>
Copy link

vercel bot commented Oct 24, 2024

@JeevaRamanathan is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (c77d415) to head (54ad6ad).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
application/parser/file/json_parser.py 60.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   33.63%   33.63%           
=======================================
  Files          65       65           
  Lines        3294     3294           
=======================================
  Hits         1108     1108           
  Misses       2186     2186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 4:08pm

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool feature, LGTM, thanks!

@dartpain dartpain merged commit 1c791f2 into arc53:main Oct 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants