Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fonts on Safari browser #1382

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

shatanikmahanty
Copy link
Contributor

Copy link

vercel bot commented Oct 26, 2024

@shatanikmahanty is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.83%. Comparing base (18ed255) to head (b99b3b8).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   33.80%   33.83%   +0.02%     
==========================================
  Files          66       67       +1     
  Lines        3310     3334      +24     
==========================================
+ Hits         1119     1128       +9     
- Misses       2191     2206      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shatanikmahanty
Copy link
Contributor Author

@ManishMadan2882 can you check once you are free if this is fine?

@ManishMadan2882
Copy link
Collaborator

@shatanikmahanty I tested on Safari, there wasn't any difference.
Could you please check it once, just make sure that you test on Safari specifically.

@shatanikmahanty
Copy link
Contributor Author

@shatanikmahanty I tested on Safari, there wasn't any difference. Could you please check it once, just make sure that you test on Safari specifically.

Hi @ManishMadan2882 here's what I am getting before adding the code:
Screenshot 2024-10-30 at 7 27 02 PM

After adding the code:
Screenshot 2024-10-30 at 7 27 16 PM

In the after image you can see if you compare that the text is slimmer.

Can you share with me the version of safari you're using to test, maybe I will be able to find any other problems that is contributing to font size issue on your device

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shatanikmahanty
Copy link
Contributor Author

@dartpain can you please merge once you are free, thanks ❤️

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:07pm

@dartpain dartpain merged commit 4ac996c into arc53:main Oct 31, 2024
8 checks passed
@shatanikmahanty shatanikmahanty deleted the fix-safari-font branch October 31, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Safari wrong fonts
3 participants