Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: empty doc selection in /stream #1384

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

ManishMadan2882
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    • Purged selectedDocs from /stream endpoint
    • Chunks will be set to zero in case of isNoneDoc (Empty).
  • Why was this change needed? (You can also link to an open issue here)
    Fixes 🐛 Bug Report: Empty document uses default document #948

Copy link

vercel bot commented Oct 26, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (05f7569) to head (1627d42).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
application/api/answer/routes.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   33.45%   33.63%   +0.18%     
==========================================
  Files          64       65       +1     
  Lines        3273     3297      +24     
==========================================
+ Hits         1095     1109      +14     
- Misses       2178     2188      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dartpain dartpain merged commit d9787e8 into arc53:main Oct 29, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Empty document uses default document
2 participants