-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt documentation to existing tests. #306
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @dartpain , To have coverage action adding a comment to the pull request, the action should have permission to write to the pull request. It is configured inside the action: |
OK, according to the section from the article: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token it is impossible to get the write permissions when merging from the public forked repository. So, |
This reverts commit 44f3538.
I'll prepare the pull request with the partial revert of coverage PR. |
Yeah, I was trying to understand that for a bit, whats the right way to set it up? |
I suppose this particular action will be functional only for PRs within one repository and doesn't work for public forks. So we can't use it here. I'll look for another solution. Maybe something like SonarCloud or similar. I'll create an issue about it or create another pull request if find a proper solution. |
Thank you! |
This PR is only about documentation change, please review.