Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt documentation to existing tests. #306

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

larinam
Copy link
Collaborator

@larinam larinam commented Aug 18, 2023

This PR is only about documentation change, please review.

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 6:20pm

@larinam
Copy link
Collaborator Author

larinam commented Aug 18, 2023

Hi @dartpain ,

To have coverage action adding a comment to the pull request, the action should have permission to write to the pull request. It is configured inside the action:
Screenshot 2023-08-18 at 17 49 52
But when I check GITHUB_TOKEN permissions, I see that it is not modified.
Screenshot 2023-08-18 at 17 49 11
Most likely permissions related to the GitHub token used in the repository (secrets.GITHUB_TOKEN) are limited and don't allow to write to pull requests.
Could you check permissions related to the GITHUB_TOKEN connected to the repo and grant permissions to write to pull requests to allow action to add comments to the pull request with the coverage statistics?

@larinam
Copy link
Collaborator Author

larinam commented Aug 21, 2023

OK, according to the section from the article: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token it is impossible to get the write permissions when merging from the public forked repository. So,

@larinam
Copy link
Collaborator Author

larinam commented Aug 21, 2023

I'll prepare the pull request with the partial revert of coverage PR.

@dartpain
Copy link
Contributor

Yeah, I was trying to understand that for a bit, whats the right way to set it up?

@larinam
Copy link
Collaborator Author

larinam commented Aug 22, 2023

I suppose this particular action will be functional only for PRs within one repository and doesn't work for public forks. So we can't use it here. I'll look for another solution. Maybe something like SonarCloud or similar. I'll create an issue about it or create another pull request if find a proper solution.
But this PR is only about the documentation and is still relevant and looks safe to be merged :)

@dartpain
Copy link
Contributor

Thank you!

@dartpain dartpain merged commit 505e12c into arc53:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants