-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add scroll to bottom button #363
Conversation
This will show the scroll to bottom button when user scrolls to top from the last message. Closes #170
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For developing this part I had to use the mock data from the app as I was not able to run the back-end app due to some issues in my python installation in WSL. I'm not super comfortable in fixing python side of issues. I also commented the code which shows the |
In the preview, the |
Good commit, Basically if user is at the bottom of the screen, the arrow should dissapear. Also even if you can't launch backend just try it with error messages too Btw looks good on mobile too! |
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 16.00% 16.02% +0.02%
==========================================
Files 59 59
Lines 2668 2664 -4
==========================================
Hits 427 427
+ Misses 2241 2237 -4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just added [endMessageRef.current] to deps, seems to fix the issue |
Congratulations @hirenchauhan2, you just earned a badge! Here it is: https://holopin.io/claim/clna3r7h1365560fmc3vyvkeoy This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
This will show the scroll to bottom button when user scrolls to top from the last message.
Closes #170