Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sidebar Icons update on changing theme #844

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Jan 31, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Fixes bug in the nav bar icons
  • Adding Custom Hook useDarkTheme() which returns as [isDarkTheme, toggleTheme]
    image
  • Why was this change needed? (You can also link to an open issue here)
  • Appropriate icons didn't display as per the selected theme.
  • Demo:
    image

Copy link

vercel bot commented Jan 31, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6058939) 19.11% compared to head (dea3853) 19.13%.
Report is 8 commits behind head on main.

Files Patch % Lines
application/api/answer/routes.py 0.00% 3 Missing ⚠️
scripts/parser/open_ai_func.py 0.00% 2 Missing ⚠️
scripts/code_docs_gen.py 0.00% 1 Missing ⚠️
scripts/old/ingest_rst.py 0.00% 1 Missing ⚠️
scripts/old/ingest_rst_sphinx.py 0.00% 1 Missing ⚠️
scripts/parser/py2doc.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   19.11%   19.13%   +0.01%     
==========================================
  Files          65       65              
  Lines        3013     3016       +3     
==========================================
+ Hits          576      577       +1     
- Misses       2437     2439       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManishMadan2882 ManishMadan2882 changed the title Fix: Nav Buttons update on changing theme Fix: Sidebar Icons update on changing theme Jan 31, 2024
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:51am

@dartpain
Copy link
Contributor

dartpain commented Feb 1, 2024

Works great, Thank you!

@dartpain dartpain merged commit 510b517 into arc53:main Feb 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants