pyflakes: fix issues and setup automation

Fixed issues reported by pyflakes and added automation for running pyflakes. Fixes #64 Signed-off-by: Sandro Bonazzola <[email protected]>
arcalot · Sep 9, 2022 · 42a3158 · 42a3158
1 parent f960763
commit 42a3158
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,6 +28,10 @@ jobs:
         run: |
           pip install sphinx
           pip install sphinx-rtd-theme
+      - name: Check with pyflakes
+        run: |
+          pip install pyflakes
+          pyflakes `find . -name "*.py"`
       - name: Test
         run: cd src && python3 -m unittest discover -v
       - name: Document

diff --git a/docs/conf.py b/docs/conf.py
@@ -5,7 +5,6 @@
 
 # -- Path setup --------------------------------------------------------------
 
-import os
 import sys
 sys.path.insert(0, '/home/sbonazzo/NotBackedUp/upstream/arcaflow-plugin-sdk-python/src')
 

diff --git a/src/arcaflow_plugin_sdk/plugin.py b/src/arcaflow_plugin_sdk/plugin.py
@@ -1,4 +1,3 @@
-import dataclasses
 import inspect
 import io
 import json

diff --git a/src/arcaflow_plugin_sdk/schema.py b/src/arcaflow_plugin_sdk/schema.py
@@ -5966,7 +5966,7 @@ def test_object_serialization(
                  "2. Your sample data is invalid according to your own rules\n" \
                  "3. There is a bug in the SDK (please report it)\n\n" \
                  "Check the error message below for details.\n\n" \
-                 "---\n\n".format(type(dc).__name__, traceback.extract_stack())
+                 "---\n\n{}".format(type(dc).__name__, traceback.extract_stack())
         result += "Error message:\n" + e.__str__() + "\n\n"
         # noinspection PyDataclass
         result += "Input:\n" + pprint.pformat(dataclasses.asdict(dc)) + "\n\n"

diff --git a/src/arcaflow_plugin_sdk/test_schema.py b/src/arcaflow_plugin_sdk/test_schema.py
@@ -9,8 +9,7 @@
 import enum
 import unittest
 
-from arcaflow_plugin_sdk.schema import PropertyType, ConstraintException, BadArgumentException, SchemaBuildException, \
-    IntType
+from arcaflow_plugin_sdk.schema import PropertyType, ConstraintException, BadArgumentException, SchemaBuildException
 
 
 class Color(enum.Enum):
@@ -422,7 +421,7 @@ class TestSubclass(TestParent):
             pass
 
         # If a is missing from 'TestSubclass', it will fail.
-        s = schema.ObjectType(
+        schema.ObjectType(
             TestSubclass,
             {
                 "a": schema.PropertyType(

diff --git a/test_example_plugin.py b/test_example_plugin.py
@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-import re
 import unittest
 import example_plugin
 from arcaflow_plugin_sdk import plugin