Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent Class Support #43

Closed
jaredoconnell opened this issue Aug 20, 2022 · 0 comments · Fixed by #44
Closed

Parent Class Support #43

jaredoconnell opened this issue Aug 20, 2022 · 0 comments · Fixed by #44
Assignees
@jaredoconnell
Labels
bug Something isn't working

Comments

@jaredoconnell
Copy link
Contributor

Please describe what you would like to see in this project

The SDK does not support parent classes. The properties are in the objects, but the annotations are missing.
The SDK should read those annotations as if they are in the child class.

Please describe your use case

This is useful when items of the SDK inherit from each other because of a shared base class.
@jaredoconnell jaredoconnell added the enhancement New feature or request label Aug 20, 2022
@jaredoconnell jaredoconnell self-assigned this Aug 20, 2022
@ghost ghost added bug Something isn't working and removed enhancement New feature or request labels Aug 21, 2022
@jaredoconnell jaredoconnell linked a pull request Aug 23, 2022 that will close this issue
Support annotations from parent classes. Closes #43 #44
Merged
jaredoconnell added a commit that referenced this issue Aug 23, 2022
@jaredoconnell
Support annotations from parent classes. Closes #43 (#44)
1c11b01 
* Support annotations from parent classes

* Add test case for inherited classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredoconnell jaredoconnell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support annotations from parent classes. Closes #43 jaredoconnell/arcaflow-plugin-sdk-python
1 participant
@jaredoconnell