Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out OneOfSchema from OneOfStringSchema and OneOfIntSchema #131

Merged
merged 31 commits into from
May 2, 2024
Merged

Factor out OneOfSchema from OneOfStringSchema and OneOfIntSchema #131

merged 31 commits into from
May 2, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Apr 27, 2024 •
edited
Loading

Changes introduced with this PR

  • Factor out OneOfSchema from OneOfStringSchema and OneOfIntSchema
  • Fix output of OneOfIntSchema's const type value to integer
  • Add test for json schema build of OneOfIntSchemas

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader marked this pull request as ready for review April 29, 2024 16:16
@mfleader mfleader self-assigned this Apr 29, 2024
jaredoconnell
jaredoconnell approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Webb and Dave should also take a look.

dbutenhof
dbutenhof reviewed Apr 29, 2024
View reviewed changes
src/arcaflow_plugin_sdk/schema.py Outdated Show resolved Hide resolved
src/arcaflow_plugin_sdk/schema.py Outdated Show resolved Hide resolved
webbnh

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

@mfleader mfleader marked this pull request as draft May 1, 2024 15:16
@mfleader mfleader marked this pull request as ready for review May 1, 2024 15:36
webbnh

This comment was marked as resolved.

Sign in to view

dbutenhof
dbutenhof approved these changes May 1, 2024
View reviewed changes
src/arcaflow_plugin_sdk/schema.py Outdated Show resolved Hide resolved
webbnh

This comment was marked as resolved.

Sign in to view

@mfleader mfleader mentioned this pull request May 2, 2024
Open
@mfleader mfleader merged commit 5ad27d8 into main May 2, 2024
4 checks passed
@mfleader mfleader deleted the oneofschema-refactor branch May 2, 2024 22:32
@mfleader mfleader linked an issue Jun 5, 2024 that may be closed by this pull request
Factor Out Common Code from OneOfStringSchema and OneOfIntSchema #128
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees

@mfleader mfleader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factor Out Common Code from OneOfStringSchema and OneOfIntSchema
4 participants
@mfleader @webbnh @jaredoconnell @dbutenhof