rename http module to _http #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrobonazzola
changed the title
ghost
approved these changes
Sep 9, 2022
ghost
suggested changes
Sep 9, 2022
renaming `http` module avoiding circular dependency issue due to naming collision with `web/http.py` within `twisted` dependency. Using `_http` as this is meant to be a private module. Fixes #61 Signed-off-by: Sandro Bonazzola <[email protected]>
ghost
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
renaming
httpmodule avoiding circular dependency issue due to naming collision withweb/http.pywithintwisteddependency.Using
_httpas this is meant to be a private module.Fixes #61
Signed-off-by: Sandro Bonazzola [email protected]
By contributing to this repository, I agree to the contribution guidelines.