Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] set log dep version as 0.4.21 #2

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[fix] set log dep version as 0.4.21 #2

merged 1 commit into from
Oct 18, 2024

Conversation

hky1999
Copy link
Contributor

@hky1999 hky1999 commented Oct 18, 2024

No description provided.

@hky1999 hky1999 requested a review from aarkegz October 18, 2024 07:55
@aarkegz
Copy link
Contributor

aarkegz commented Oct 18, 2024

Why don't we fix it at 0.4.21?

@hky1999
Copy link
Contributor Author

hky1999 commented Oct 18, 2024

Why don't we fix it at 0.4.21?

I fix it as 0.4.21 in axvm, I believe that it will cause axdevice to use a 0.4.21 version.

for generality consideration

@aarkegz
Copy link
Contributor

aarkegz commented Oct 18, 2024

Why don't we fix it at 0.4.21?

I fix it as 0.4.21 in axvm, I believe that it will cause axdevice to use a 0.4.21 version.

for generality consideration

OK. I think that's OK because axdevice it self won't trigger log's bug.

aarkegz
aarkegz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@aarkegz aarkegz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hky1999 hky1999 merged commit 69c0c2b into master Oct 18, 2024
10 checks passed
@hky1999 hky1999 deleted the log_version branch October 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarkegz aarkegz aarkegz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hky1999 @aarkegz