Enhanced MemoryAddr
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But I think |
Yes, I think so. But having |
I just read your do as donot by mistake, yep, they all LGTM |
hky1999
approved these changes
Aug 20, 2024
Merged
hky1999
reviewed
Aug 21, 2024
equation314
reviewed
Aug 22, 2024
equation314
reviewed
Aug 23, 2024
memory_addr/src/range.rs
Outdated
| @@ -98,7 +92,11 @@ where | |||
| /// ``` | |||
| #[inline] | |||
| pub fn size(self) -> usize { | |||
| usize!(self.end) - usize!(self.start) | |||
| if self.is_empty() { | |||
There was a problem hiding this comment.
To handle empty ranges with start > end. I think we should make it clear what it means and what the behavior these methods should have when start > end. Maybe just reject them with a checked new and write a new_unchecked?
…tailed unit tests
|
I think this and #3 are mergeable as the behavior of the structures and functions has been clarified by docs and tested by doc and unit tests now. @hky1999 @equation314 |
equation314
approved these changes
Aug 26, 2024
aarkegz
added a commit
that referenced
this pull request
Aug 26, 2024
* use local `memory_addr` for `memory_set`, update `memory_set`, move generic params of mapping structures into `MappingBackEnd` as associated types * fix docs * Enhanced `MemoryAddr` (#4) * demo: what if we add more bounds to `MemoryAddr` * remove arithmetic bounds for `MemoryAddr`, add some provided methods * rename `MemoryAddr::sub_addr` to `MemoryAddr::offset_from` * remove a wrong bug todo * add two more functions to `VirtAddr` * add `add` and `sub` to `MemoryAddr` * clarify the behavior of arithmetic operations of `MemoryAddr`, add detailed unit tests * formatted * add `overflowing_add/sub` to `MemoryAddr` * add `checked_add/sub` to `MemoryAddr` * `AddrRange` candidate B: allow malformed ranges and treat them as empty * doc and tests improvement for `MemoryAddr` and `AddrRange` * update `PageIter` * formatted * even more tests, ready to merge * switch to `AddrRange` candidate A * add `sub_addr` series to `MemoryAddr`, improve panic messages in `MemoryAddr` and `AddrRange` * some small code improvements * bump version to 0.3.0 * update function calls about address arithmetic operations in `MemoryArea`s and `MemorySet`s * loosen memory area shrink check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we can get if we add more bounds to
MemoryAddr. I do think it's worth it.