Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial Views API #10704

Closed
whatisgalen opened this issue Mar 22, 2024 · 1 comment
Closed

Spatial Views API #10704

whatisgalen opened this issue Mar 22, 2024 · 1 comment
Assignees
@whatisgalen @aj-he @csmith-he @phudson-he

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Mar 22, 2024 •
edited by csmith-he
Loading

Aim: To create an API and related UI for managing the spatial views (which are currently administered using SQL).

The API will allow the creation, editing and deletion of an individual spatial view or on a list of spatial views - these changes can only be carried out if the Arches user has permission to make them on the spatial view(s) in question.

The UI will be developed using Vue.js. The UI will adhere to Accessibility guidelines as defined in the ReadTheDocs.
@chiatt chiatt added this to pipeline Mar 22, 2024
@whatisgalen
Copy link
Member Author

@aj-he @csmith-he @phudson-he

whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
init commit for SpatialView api re #10704
c92bd70
@csmith-he csmith-he moved this to 🏗 In Progress in pipeline Mar 22, 2024
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
creates get method to return permitted spatial view by id or slug, el…
c9712db 
…se list of all perm spatial views re #10704
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
updates spatial view api post and delete methods to get id or slug fr…
45c5df4 
…om request object re #10704
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
completes delete method for spatial view api re #10704
f0d640e
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
ensures post requests done by user with App Admin perms re #10704
67b660e
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
adds reqs check for all required fields on spatial view api in post c…
66bfbc4 
…reate re #10704
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
creates new spatialview instance if spatialview api post method actio…
e2196aa 
…n == create re #10704
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
creates validation method for attribute nodes assigned to spatial vie…
768cba9 
…w re #10704
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
fleshes out post update action in spatial view api re #10704
fc862fe
whatisgalen added a commit that referenced this issue Mar 22, 2024
@whatisgalen
imports django ObjectDoesNotExist error for updating, creating in pos…
b26056e 
…t method of spatial view api re #10704
whatisgalen added a commit that referenced this issue Mar 23, 2024
@whatisgalen
commits url for api/spatialview re #10704
4e5dea8
whatisgalen added a commit that referenced this issue Mar 23, 2024
@whatisgalen
conforms spatial view api to separate crud methods re #10704
c00dcb4
whatisgalen added a commit that referenced this issue Mar 23, 2024
@whatisgalen
renames geometrynodeid field to geometrynode to represent node obj re #…
d875d51 
…10704
whatisgalen added a commit that referenced this issue Mar 23, 2024
@whatisgalen
commits language field to SpatialView model re #10704
f304107
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
fixes typo in JSONResponse status kwarg re #10704
afe6550
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
sets default value for isactive on spatial view api post method re #1…
2f4a516 
…0704
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
sets default value for ismixedgeometrytypes in spatial view api post,…
3d840cc 
… also fixes accessing description from payload re #10704
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
includes url kwarg identifier for either uuid or slug, regex, in spat…
cac12de 
…ial view api methods re #10704
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
creates spatial view api identifier helper method to distinguish from…
bbb7cda 
… flug param in API methods re #10704
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
general cleanup of spatial view api methods re #10704
76db434
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
cleans up spatial view api delete method re #10704
a51a3e7
whatisgalen added a commit that referenced this issue Mar 26, 2024
@whatisgalen
commits migration to alter column name for spatial view and adds FK l…
87ccac9 
…anguage re #10704
@whatisgalen whatisgalen mentioned this issue Mar 26, 2024
Closed
6 tasks
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
refactors spatialview attrnode logic to model null and blank contraints
5e63236 
archesproject#10704
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
adds contraint on language deletion to ensure spatialviews are manage…
f4b0865 
…d first archesproject#10704
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
refactor geomnode validation logic managed by model archesproject#10704
ce78cba
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
more refactor geomnode validation logic managed by model archesprojec…
4ac4155 
…t#10704
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
changes clean calls to full_clean calls archesproject#10704
d16a2e3
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
nit archesproject#10704
e438b48
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
improve readability archesproject#10704
f449b31
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
removes slug validation handled by field validator archesproject#10704
0b9e7da
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
reduced comparison query overhead archesproject#10704
733ca5d
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
refactor routes based on feedback archesproject#10704
48bfd98 
- removes need to check for uuid which is done in urls.py
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
add error if user includes identifier on POST archesproject#10704
edaef3f 
- the url was refactorted to a single route on review advice.
- identifier should not be provided as it is generated on creation.
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
adds error in case spatialviewid sent in POST json_data archesproject…
c8e80dc 
…#10704

- spatialviewid is generated by the model and return in response
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
adds checking for spatialviewid being included in POST archesproject#…
4640c69 
…10704

- includes api test
- fixes missing identifier parameter on GET all and POST tests
- moved get test after post test
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
nit suppress expected warnings archesproject#10704
3c8df6c
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
moves spatialview json object creation to the model archesproject#10704
4c49f5a
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
removed incorrect default parameter value archesproject#10704
8b9c966
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
nit remove mutable default parameter value archesproject#10704
d8522fa
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
nit fixed missed to_json change archesproject#10704
930704c
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
refactored test to use Spatialview.to_json() archesproject#10704 arch…
f622327 
…esproject#10705
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
refactored api validation archesproject#10704
d2b2c3d
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 14, 2024
@aj-he
nit spelling correction archesproject#10704
41cb96f
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
change successful delete status code to NO_CONTENT archesproject#10704
fd4d3ad
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
corrects api delete test archesproject#10704
241b940
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
adds review suggestions archesproject#10704
3b963d0 
- use standard JSONDeserializer
- raise_exception set on group_required decorator
- refactor geometrynodeid data transformation
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
adds review changes archesproject#10704
5c4f79c 
- refactored language code transformation step
- change reponse code when sv to edit or delete is not found
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
update migration dependency archesproject#10704
e3e70c8
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
nit corrected route order archesproject#10704
998cb39
aj-he added a commit to HistoricEngland/arches that referenced this issue Aug 15, 2024
@aj-he
nit black formatting archesproject#10705 archesproject#10704
06465f0
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatisgalen whatisgalen

@aj-he aj-he

@csmith-he csmith-he

@phudson-he phudson-he

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@whatisgalen @aj-he @csmith-he @jacobtylerwalls @phudson-he