Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityStream is out of order -- Updates can't be before Creates #9769

Closed
azaroth42 opened this issue Jul 12, 2023 · 1 comment · Fixed by #10662
Closed

ActivityStream is out of order -- Updates can't be before Creates #9769

azaroth42 opened this issue Jul 12, 2023 · 1 comment · Fixed by #10662
Assignees
Labels
Type: Bug Something isn't working

Comments

@azaroth42
Copy link
Collaborator

For example:

Screenshot 2023-07-12 at 2 00 51 PM

The Update to 53de8bae cannot happen before it was Created. Updates can only be after Creates.

@chiatt chiatt added this to pipeline Jul 12, 2023
@azaroth42
Copy link
Collaborator Author

azaroth42 commented Jul 18, 2023

I think the fix is in app/models/resource.py by moving the self.save_edit() line in save() to before the tile.save() line ... so would become line 228.

However, a change for #9768 that meant no tile entries were generated during resource.save() would also fix the issue, as there wouldn't be updates to be in the wrong order :)

@chiatt chiatt added the Type: Bug Something isn't working label Jul 20, 2023
@chiatt chiatt moved this to 📋 Backlog in pipeline Jul 20, 2023
@njkim njkim self-assigned this Mar 4, 2024
@njkim njkim moved this from 📋 Backlog to 🏗 In Progress in pipeline Mar 6, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Mar 25, 2024 that will close this issue
6 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Mar 25, 2024
jacobtylerwalls added a commit that referenced this issue Mar 26, 2024
jacobtylerwalls added a commit that referenced this issue Mar 26, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants