Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 7.5 breaking changes with <select> admonition #10611

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update 7.5 breaking changes with <select> admonition #10611

merged 2 commits into from
Feb 15, 2024

Conversation

jacobtylerwalls
Copy link
Member

Came up in an Arches implementation upgrading to 7.5.

johnatawnclementawn
johnatawnclementawn approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼 , I added a comment about adding an aria-label by using data-label. That usage only applies to selectWoo elements

@johnatawnclementawn johnatawnclementawn merged commit 10fdc68 into dev/7.5.x Feb 15, 2024
2 checks passed
@johnatawnclementawn johnatawnclementawn deleted the select-admonition branch February 15, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnatawnclementawn johnatawnclementawn johnatawnclementawn approved these changes

Assignees

@johnatawnclementawn johnatawnclementawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @johnatawnclementawn