Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added required backslash changes for windows compatibility #11606

Merged

Conversation

jkemper-pca
Copy link
Contributor

This is based on the changes that we needed to get v7.6.2 running on our Windows environment after upgrading from v7.5

Forum discussion

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

As done previously in another PR, the webpack code can get strings wrong when running on a Windows environment due to the use of backslashes rather than forward slashes in Unix environments. This change replaces the backslashes with forward slashes where it is required.

Issues Solved

Closes #

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

@jkemper-pca jkemper-pca marked this pull request as ready for review November 7, 2024 20:01
@chiatt chiatt self-requested a review November 7, 2024 21:08
@chiatt chiatt self-assigned this Nov 7, 2024
@chiatt
Copy link
Member

chiatt commented Nov 7, 2024

@jkemper-pca Could you add a line under Bug Fixes and Enhancements in releases/7.6.3.md that describes this change?

Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@chiatt
Copy link
Member

chiatt commented Nov 8, 2024

@jkemper-pca Could you add a line under Bug Fixes and Enhancements in releases/7.6.3.md that describes this change?

No need to do this. I'm going to take care of it while preparing the patch release.

@chiatt chiatt merged commit ceaa937 into archesproject:dev/7.6.x Nov 8, 2024
7 checks passed
chiatt added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants