Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for slow reports, re #11748 #11749

Merged
merged 3 commits into from
Jan 24, 2025
Merged

fix for slow reports, re #11748 #11749

merged 3 commits into from
Jan 24, 2025

Conversation

apeters
Copy link
Member

@apeters apeters commented Jan 24, 2025

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

This bug was tracked down to a very slow running query. It turns out that this query counted the number of related resources. This is used in the related resource graph in search and elsewhere, but was unneeded in the report.
Adding a flag that the report can set was used to omit that expensive call. Below are screen shots of endpoint profiling showing the expensive query being eliminated.

Before the update:
Screenshot 2025-01-23 at 4 58 30 PM

After the update:
Screenshot 2025-01-23 at 5 05 17 PM

Issues Solved

Closes #11748

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

  • Sponsored by:
  • Found by: @apeters
  • Tested by: @

Further comments

@apeters apeters requested a review from chiatt January 24, 2025 03:27
@chiatt chiatt merged commit 9451385 into dev/7.6.x Jan 24, 2025
7 checks passed
@chiatt chiatt deleted the 11748_slow_reports branch January 24, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants