Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module-info.class from artifact #23

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove module-info.class from artifact #23

merged 2 commits into from
Apr 8, 2024

Conversation

Kotori316
Copy link
Contributor

Closes #22

This declaration is needed to avoid "Ignoring duplicate module on SecureModuleFinder" warning in recent forge.
Without this, these 2 jars are treated as same module and one will be removed from class loader.
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@shedaniel shedaniel merged commit 7e26bed into architectury:master Apr 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with forge 49.0.38 due to invalid module-info.class
3 participants