Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for ComputeImageSize.scala #45

Closed
ruebot opened this issue Oct 2, 2017 · 4 comments
Closed

Create tests for ComputeImageSize.scala #45

ruebot opened this issue Oct 2, 2017 · 4 comments
Assignees
@greebie
Labels
tests

Comments

@ruebot
Copy link
Member

ruebot commented Oct 2, 2017 •
edited
Loading

ComputeImageSize.scala has no test coverage. We need to create tests for it.
@ruebot ruebot added the tests label Oct 2, 2017
@greebie greebie self-assigned this Oct 4, 2017
@greebie
Copy link
Contributor

greebie commented Oct 6, 2017

pass a null value to this function can cause a NullPointerException that will not be caught. This would be prevented by moving the try above the val in = InputBuffer call.

@ruebot
Copy link
Member Author

ruebot commented Oct 6, 2017

Cool. Do you want to update both the test and ComputeImageSize.scala? If so, go for it!

@greebie
Copy link
Contributor

greebie commented Oct 6, 2017

Thanks. will do.

@greebie greebie mentioned this issue Oct 6, 2017
Merged
ruebot pushed a commit that referenced this issue Oct 6, 2017
@greebie @ruebot
Increase coverage for ComputeImageSize. #45 (#89)
22c5ba0 
* Increase coverage for ComputeImageSize.

* Use different method for codecoverage.
@ruebot
Copy link
Member Author

ruebot commented Oct 6, 2017

Resolved with: 22c5ba0

@ruebot ruebot closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greebie greebie

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greebie @ruebot