Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Tika - security vulnerabilities; resolves #131. #285

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Oct 17, 2018

GitHub issue(s): #131

What does this Pull Request do?

Update Apache Tika to 1.19.1 for the following security vulnerabilities:

How should this be tested?

TravisCI should take care of it. If there is any language analysis scripts laying around, we should double check those.

Additional Notes:

This creates a build warning:

[WARNING] /home/nruest/git/aut/src/main/scala/io/archivesunleashed/matchbox/DetectLanguage.scala:33: warning: class LanguageIdentifier in package language is deprecated: see corresponding Javadoc for more information.
[INFO]       new LanguageIdentifier(input).getLanguage
[INFO]           ^
[WARNING] one warning found

Follow-on ticket #286

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Out of curiosity, tested the .keepLanguages command and all still works.

@ruebot
Copy link
Member Author

ruebot commented Oct 17, 2018

phew

@codecov-io
Copy link

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          41       41           
  Lines        1046     1046           
  Branches      192      192           
=======================================
  Hits          736      736           
  Misses        244      244           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4f9bb...1f27d8e. Read the comment docs.

@ianmilligan1 ianmilligan1 merged commit b9260be into master Oct 17, 2018
@ianmilligan1 ianmilligan1 deleted the issue-131 branch October 17, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants