-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak hasDate to handle Seq. #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses #425 - Add test for hasDate
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 41 41
Lines 1534 1534
Branches 283 282 -1
=======================================
Hits 1192 1192
Misses 217 217
Partials 125 125 |
Documentation PR archivesunleashed/aut-docs#48 |
ianmilligan1
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with both !hasDate
and hasDate
, works nicely!
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Mar 26, 2020
- See: - archivesunleashed/aut#430 - archivesunleashed/aut#429 - Split filters documentation out in an RDD page, and DF page - Update root ToC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s):
What does this Pull Request do?
Follow on to #429, Tweak
hasDate
to handle Seq.How should this be tested?
...and if you want, something like: