Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak hasDate to handle Seq. #430

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Tweak hasDate to handle Seq. #430

merged 6 commits into from
Mar 23, 2020

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Mar 23, 2020

GitHub issue(s):

What does this Pull Request do?

Follow on to #429, Tweak hasDate to handle Seq.

How should this be tested?

  • TravisCI

...and if you want, something like:

import io.archivesunleashed._
import io.archivesunleashed.df._

val dates = Array("2008", "200908", "20070502")

RecordLoader.loadArchives("/home/nruest/Projects/aut/sample-data/geocities", sc)
  .all()
  .select($"url", $"crawl_date")
  .filter(!hasDate($"crawl_date", lit(dates)))
  .show(10, false)  

@ruebot ruebot requested a review from ianmilligan1 March 23, 2020 14:55
@ruebot ruebot changed the title Issue 425 dates Tweak hasDate to handle Seq. Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #430 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          41       41           
  Lines        1534     1534           
  Branches      283      282    -1     
=======================================
  Hits         1192     1192           
  Misses        217      217           
  Partials      125      125           

@ruebot
Copy link
Member Author

ruebot commented Mar 23, 2020

Documentation PR archivesunleashed/aut-docs#48

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both !hasDate and hasDate, works nicely!

@ianmilligan1 ianmilligan1 merged commit 92b5f2d into master Mar 23, 2020
@ianmilligan1 ianmilligan1 deleted the issue-425-dates branch March 23, 2020 17:25
ruebot added a commit to archivesunleashed/aut-docs that referenced this pull request Mar 26, 2020
- See: 
  - archivesunleashed/aut#430
  - archivesunleashed/aut#429
- Split filters documentation out in an RDD page, and DF page 
- Update root ToC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants