-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphml output to CommandLineApp and DomainGraphExtractor. #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 78.04% 78.18% +0.13%
==========================================
Files 43 43
Lines 1558 1586 +28
Branches 286 289 +3
==========================================
+ Hits 1216 1240 +24
- Misses 217 218 +1
- Partials 125 128 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 🤦 comment from me below (but the file outputs are great!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great on all fronts! (give me a thumbs up if you're happy to have this PR merged, @ruebot, looks good to me)
@ianmilligan1 sure, let's use the following as a commit message: Add graphml output to CommandLineApp and DomainGraphExtractor.
|
GitHub issue(s): #435
What does this Pull Request do?
Add graphml output to CommandLineApp and DomainGraphExtractor.
How should this be tested?
TravisCI +
Those both should have the same line count.
For example:
Additional Notes:
I should add a test as well for WriteGraphmlDF similar to what we have for WriteGexf. So, don't merge this right away, but feel free to test it and make sure it works.
This might also take care of the remainder of #223 and supersede #397? 👋 @SinghGursimran