Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-travis] Add spark-submit option to README; resolves #444. #446

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Apr 15, 2020

GitHub issue(s): #444

What does this Pull Request do?

Add spark-submit option to README.

How should this be tested?

Let me know if this works. Tried to get it fairly simply, and just link out to the more robust documentation. Link.

@ruebot ruebot requested review from ianmilligan1 and SamFritz April 15, 2020 20:17
README.md Outdated
The Toolkit offers a variety of extraction jobs with
[`spark-submit`](https://spark.apache.org/docs/latest/submitting-applications.html)
. These extraction jobs have a few configuration options, and analysis can use
RDD or DataFrame is most cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo
is -> in

@ianmilligan1
Copy link
Member

^^^ Oops, hit "approved" but did catch one minor typo @ruebot (apologies on the butterfinger). But this is great, and it really occurs to me that we should be promoting spark-submit more as this is so straightforward.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files          40       40           
  Lines        1395     1395           
  Branches      265      265           
=======================================
  Hits         1054     1054           
  Misses        218      218           
  Partials      123      123           

@ianmilligan1 ianmilligan1 merged commit d5a0433 into master Apr 15, 2020
@ianmilligan1 ianmilligan1 deleted the issue-444 branch April 15, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants