Setup cobertura better so we have local html reports. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great - very useful. And I think @greebie will love this! |
|
Hrm, looks like I need build section to report to CodeCov still https://github.com/archivesunleashed/aut/pull/94/files#diff-600376dffeb79835ede4a0b285078036L189 I'll add that back and and see if CodeCov fires. |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 38 38
Lines 747 747
Branches 141 141
=======================================
Hits 477 477
Misses 221 221
Partials 49 49Continue to review full report at Codecov.
|
|
There we go. Should be good to merge now. |
ianmilligan1
approved these changes
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s):
What does this Pull Request do?
Adds a cobertura reporting section, and removes unneeded config from build section for cobertura.
How should this be tested?
Build locally with
mvn cobertura:coberturaand once the build completes, you should have atarget/site/coberturadirectory. Openindex.htmland should could see something along the lines of this:Tag @greebie you might be very interested in this. Maybe @ianmilligan1 too?