Minor fix to improve coverage. #55 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
+ Coverage 63.85% 65.15% +1.3%
=========================================
Files 38 38
Lines 747 752 +5
Branches 141 141
=========================================
+ Hits 477 490 +13
+ Misses 221 214 -7
+ Partials 49 48 -1
Continue to review full report at Codecov.
|
Improve ExtractBoilerpipe to avoid null pointer exception on null call. Add placeholders to ExtractEntities for further exploration.
Improve coverage on ExtractBoilerPipeText
|
There! Two sources covered to 100%! |
ruebot
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title of this pull-request should be a brief description of what the pull-request fixes/improves/changes. Ideally 50 characters or less.
GitHub issue(s):
#55, #47
What does this Pull Request do?
Adds test for no path.
How should this be tested?
Codecov & Travis.
Additional Notes:
The test merely ensures that an empty filepath results in a Unit() / Void response. This does not fully test that there no file is created. The test could be improved by including a Boolean response (true for create file and false for no file) instead of a unit.
Interested parties
Tag (@ mention) interested parties.
Thanks in advance for your help with the Archives Unleashed Toolkit!