Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Android release build #12

Closed
wants to merge 1 commit into from
Closed

fix Android release build #12

wants to merge 1 commit into from

Conversation

gianpaj
Copy link
Contributor

@gianpaj gianpaj commented Apr 10, 2018

This was causing a crash when opening a release (production) build.

adb logcat

04-10 13:24:56.417 12009 12036 E ReactNativeJS: undefined is not an object (evaluating 'l.View.propTypes.style')

facebook/react-native@1129c60
28 Mar 2017

    // ReactNative `View.propTypes` have been deprecated in favor of
    // `ViewPropTypes`. In their place a temporary getter has been added with a
    // deprecated warning message. Avoid triggering that warning here by using
    // temporary workaround, __propTypesSecretDontUseThesePlease.

See also:
facebook/react-native#16352

@ardaogulcan
Copy link
Owner

Thank you for the PR. I have accepted another PR for this issue as it also covers backward compatibility. Issue resolved in v0.0.9

@gianpaj gianpaj deleted the patch-1 branch April 14, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants