Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple gRPC subgraphs in a supergraph #8203

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Dec 29, 2024

Handle multiple gRPC services correctly in a supergraph

Previously multiple directives on Query type conflicting, which needs to be fixed on Gateway runtime later, but for now, it should be already in the transport directive. And this change fixes the issue before the gateway runtime fix.

Generated schema will be different so this can be considered a breaking change but it will be no functional change for the existing users.

Closes #8201
Fixes #7962

Copy link
Contributor

github-actions bot commented Dec 29, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Dec 29, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/grpc 0.107.0-alpha-20241229115416-4ccc09e0de79929094eb62e42fd3c201756b5355 npm ↗︎ unpkg ↗︎
@omnigraph/grpc 0.2.0-alpha-20241229115416-4ccc09e0de79929094eb62e42fd3c201756b5355 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-grpc 0.2.0-alpha-20241229115416-4ccc09e0de79929094eb62e42fd3c201756b5355 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Dec 29, 2024

💻 Website Preview

The latest changes are available as preview in: https://f416f90d.graphql-mesh.pages.dev

@ardatan ardatan merged commit c541164 into master Jan 2, 2025
15 checks passed
@ardatan ardatan deleted the grpc-multiple-services-fix branch January 2, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V1] Object at path is not a service constructor (only last added grpc service is ran correctly)
1 participant